From 03024c968e0ebc268914b699536292bdb8943ac6 Mon Sep 17 00:00:00 2001
From: Andrea Burattin <andrea.burattin@gmail.com>
Date: Fri, 25 Mar 2022 23:06:58 +0100
Subject: [PATCH] Improved code quality
---
.../java/beamline/tests/ResponsesTest.java | 21 ++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/src/test/java/beamline/tests/ResponsesTest.java b/src/test/java/beamline/tests/ResponsesTest.java
index 243181a..b32b63a 100644
--- a/src/test/java/beamline/tests/ResponsesTest.java
+++ b/src/test/java/beamline/tests/ResponsesTest.java
@@ -1,10 +1,9 @@
package beamline.tests;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
import java.util.Random;
import java.util.UUID;
@@ -48,15 +47,23 @@ public class ResponsesTest {
assertEquals(df, df2);
assertNotEquals(df, df3);
assertNotEquals(null, df);
- assertNotEquals("-", df);
- assertEquals(df, df);
-
- assertTrue(df.hashCode() == df2.hashCode());
- assertFalse(df.hashCode() == df3.hashCode());
assertEquals("c1", df.getCaseId());
}
+ @Test
+ public void test_equals() throws EventException {
+ BEvent e21 = BEvent.create("p", "a", "c1");
+ BEvent e22 = BEvent.create("p", "b", "c1");
+ BEvent e23 = BEvent.create("p", "a", "c2");
+ BEvent e24 = BEvent.create("p", "b", "c2");
+
+ DirectlyFollowsRelation df = new DirectlyFollowsRelation(e21, e22);
+ DirectlyFollowsRelation df2 = new DirectlyFollowsRelation(e23, e24);
+
+ assertThat(df).isEqualTo(df).hasSameHashCodeAs(df2);
+ }
+
@Test
public void string_tests() {
String unique = UUID.randomUUID().toString();
--
GitLab